A few weeks ago I wrote about Contributing to Firefox on WinXP,
and last night, my patch got committed to the trunk! Whenever the next Firefox point release comes out, millions of people
will be using the simple for loop that I wrote. Here's how the process worked:
- 11-30-2005: submitted patch and requested review
- 12-04-2005: passed review
- 12-14-2005: I politely asked around on #xul and
#developers if there was anything else I was expected to do
before the patch was committed. I was told to email the reviewer or make a comment on the bug. I opted to make
a comment on the bug.
- 12-14-2005: Gavin Sharp replied to my comment apologizing for the delay, and committed my patch.
So, except for the 10-day delay and slight confusion over my role, I'd say it went pretty smoothly. This experience
certainly encourages me to make more contributions. I've been using
Sunbird for calendar stuff, and have seen a few minor
glitches in that, maybe I'll toss in a patch or two there next.